-
Notifications
You must be signed in to change notification settings - Fork 31
Update motorkit_stepper_simpletest.py #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add delay
I think How about making the delay a const like thing? That way it can be tweaked as needed easily. Esp. since there are multiple loops in STEP_DELAY = 0.01
for i in range(100):
kit.stepper1.onestep()
time.sleep(STEP_DELAY) |
yeah i didnt get to work on the test/code this weekend, but all the examples that have a stepper should have a STEP_DELAY! |
Oh yeah, there's also |
yeah i think its fine to have there too, that one is mimic'd from the original Python library |
Hmm. Maybe time.sleep is too crude? |
we used sleep in the previous library |
Just trying to make sure / remember - this PR was for #18, right? |
yah i htink so! |
@caternuson This has been hanging for a while. Any reason not to approve this? |
@dhalbert not that i can remember. if there is anything, can just reopen. |
Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.8.1 from 3.8.0: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#56 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#55 from philippkeller/master > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#53 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 1.1.6 from 1.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#19 from jerryneedell/jerryn_clientid > disabling pypi deploy via actions > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#17 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#13 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_MotorKit to 1.3.2 from 1.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_MotorKit#19 from adafruit/ladyada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_MotorKit#22 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_MotorKit#21 from adafruit/dherrada-patch-1
add delay